Upstream QoS SAI test by wendani · Pull Request #1119 · sonic-net/sonic-mgmt

wendani · 2019-09-18T20:05:06Z

Description of PR

Summary:
The development & maintenance have been in stealth mode for about 2 years. The initial commits are delivered by Mellanox team. Thanks to their initiative hard work and efforts. We believe it is time to contribute the codes to the community for better quality and maintenance.

Test case coverage:

PFC XOFF test
PFC XON offset test
Headroom pool size test
Lossy queue drop state test
DSCP to queue mapping test
DWRR scheduling test
PG shared watermark test for both lossy and lossless traffic
PG headroom watermark test (lossless only)
Queue shared watermark test for both lossy and lossless traffic
Buffer pool watermark test for both lossy and lossless traffic
DSCP to PG mapping test
DOT1P to PG mapping test
DOT1P to queue mapping test

sudo ansible-playbook test_sonic.yml -i str --limit str-a7050-acs-1 --vault-password-file=../ansible_passwd -e testcase_name=qos_sai -e testbed_name=vms2-5-t0-7050-1 -e ptf_portmap=roles/test/files/mlnx/default_interface_to_front_map.ini -vvvv

Fixes # (issue)

Type of change

[] Bug fix
[] Testbed and Framework(new/improvement)
[] Test case(new/improvement)

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

A first running version based on Mellanox commits and patches Manually add arp entry if arp aging issue is on the dut

Signed-off-by: Wenda Ni <[email protected]>

clear_port_all_stats clear_port_all_stats is not implemented in brcm sai Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

…eceive port Signed-off-by: Wenda Ni <[email protected]>

clear_port_all_stats Assert no EGRESS_DROP on dur transmit port not on its receive port Signed-off-by: Wenda Ni <[email protected]>

…ling clear_port_all_stats Add test assertion that lossy traffic does not generate PFC Signed-off-by: Wenda Ni <[email protected]>

…ear_port_all_stats Signed-off-by: Wenda Ni <[email protected]>

DscpMappingPB, LossyQueueTest, and WRRtest Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

… null Signed-off-by: Wenda Ni <[email protected]>

qos_get_max_buff_size.yml Signed-off-by: Wenda Ni <[email protected]>

Move XON and XOFF limit queries to the last because it is only specific to ingress lossless Signed-off-by: Wenda Ni <[email protected]>

queue set Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

…buff_size.yml Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

Mellanox-specific Signed-off-by: Wenda Ni <[email protected]>

With this, the test can run on td2. Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

TODO: 1) Fix brcm's specific way of pause egress with a rpc call (need sai support) 2) The number of packets to trigger PFC and ingress drop is hard-coded according to the current buffers configuration; need to make it adpative to calculate based on the redis-cli query Signed-off-by: Wenda Ni <[email protected]>

…mlnx devices Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

SAI_PORT_STAT_ETHER_STATS_DROP_EVENTS Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

Refactor PFCtest Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

…ending event Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

shared watermark test Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

mapping test Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

Add egress lossy profile query Signed-off-by: Wenda Ni <[email protected]>

Signed-off-by: Wenda Ni <[email protected]>

Upstream QoS SAI test

Update sonic-sairedis submodule pointer to include the following: * 1d3720e Added Flex Counters support for tunnel counters (sonic-net#886) ([sonic-net#1120](sonic-net/sonic-sairedis#1120)) * 6469456 [lgtm] Add uuid library (sonic-net#1119) ([sonic-net#1126](sonic-net/sonic-sairedis#1126))

…e submodule head (sonic-net#12149) linkmgrd: * 05e5f4c 2022-09-20 | [Active-Active] flaky LinkmgrdBootupSequence unit tests (sonic-net#134) (HEAD -> 202205) [Jing Zhang] * 16fcadf 2022-09-13 | [active-standby] update warmboot reconciliation logic (sonic-net#129) [Jing Zhang] * e656a87 2022-09-09 | [active-active] shutdown link prober when starting as isolated (sonic-net#130) [Jing Zhang] uttilities: yinxi@ying-dev-vm-01:~/src/sonic-202205/src/sonic-utilities$ git hist github/202205..HEAD * 562188f 2022-09-14 | Use 'default' VRF when VRF name is not provided (sonic-net#2368) (HEAD -> 202205) [Sumukha Tumkur Vani] * c50ba4f 2022-09-20 | [minigraph] add option to specify golden path in load_minigraph (sonic-net#2350) [jingwenxie] * cec5ab2 2022-09-20 | [GCU]Remove GCU unique lane check for duplicate lanes platforms (sonic-net#2343) [jingwenxie] * 8d20771 2022-09-15 | Vnet_route_check Vxlan tunnel route update. (sonic-net#2281) [siqbal1986] swss: * 88371f7 2022-09-21 | [ci] Only when test stage succeeded or succeededwithissues, PR run Gcov (sonic-net#2460) (HEAD -> 202205) [Liu Shilong] * c11dbd7 2022-09-15 | [QoS] Enforce drop probability only for colors whose WRED are enabled (sonic-net#2422) [Stephen Sun] sairedis: * 80928dd 2022-09-06 | [lgtm] Add uuid library (sonic-net#1119) (HEAD -> 202205, github/202205) [Kamil Cudnik] * c147dd0 2022-09-16 | [202205][vslib]: Add SAI_PORT_ATTR_OPER_SPEED get sonic-net#1123 [Ze Gan] platform-daemon: * 9cf8adf 2022-09-21 | [ycabled] add notification for gRPC connection state transitions to IDLE/TRANSIENT_FAILURE (sonic-net#295) (HEAD -> 202205) [vdahiya12] * 1e07ae3 2022-09-20 | Use get() to fetch default value from dictionary for port admin_status sonic-net#286 [anamehra] * 157f483 2022-09-15 | [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285) [Prince George] Signed-off-by: Ying Xie <[email protected]>

Submodule src/sonic-swss 49c9c16..1bc989a: > Fix pfc watchdog compile error (sonic-net#1119) Signed-off-by: Ying Xie <[email protected]>

wendani and others added 30 commits September 18, 2019 11:10

Merged PR 804404: Add qos_sai test

330cacf

A first running version based on Mellanox commits and patches Manually add arp entry if arp aging issue is on the dut

Change alpha to use float filter as it can be non-integer

53ffd43

Signed-off-by: Wenda Ni <[email protected]>

Change PFCXonTest to use incremental counter values to bypass calling

e806b11

clear_port_all_stats clear_port_all_stats is not implemented in brcm sai Signed-off-by: Wenda Ni <[email protected]>

Change DscpMappingPB to use incremental counter values to bypass calling

97f086d

clear_port_all_stats clear_port_all_stats is not implemented in brcm sai Signed-off-by: Wenda Ni <[email protected]>

Correct code format

7851561

Signed-off-by: Wenda Ni <[email protected]>

InPFCXonTest, assert no EGRESS_DROP on dut transmit port not on its r…

064946f

…eceive port Signed-off-by: Wenda Ni <[email protected]>

Change PFCtest to use incremental counter values to bypass calling

09fb91f

clear_port_all_stats Assert no EGRESS_DROP on dur transmit port not on its receive port Signed-off-by: Wenda Ni <[email protected]>

Change LossyQueueTest to use incremental counter values to bypass cal…

210b2c7

…ling clear_port_all_stats Add test assertion that lossy traffic does not generate PFC Signed-off-by: Wenda Ni <[email protected]>

Change WRRtest to use incremental counter values to bypass calling cl…

caa6fac

…ear_port_all_stats Signed-off-by: Wenda Ni <[email protected]>

Clean up call to sai_thrift_clear_all_counters in PFCXonTest, PFCtest,

cfe49b4

DscpMappingPB, LossyQueueTest, and WRRtest Signed-off-by: Wenda Ni <[email protected]>

Add qos_sai test profile for Arista-7050-QX-32S

26b6245

Signed-off-by: Wenda Ni <[email protected]>

Add error message if redis-cli query for buffer profile table returns…

13941c8

… null Signed-off-by: Wenda Ni <[email protected]>

Be specific on the type of buffer profile we get from dut when calling

cc29731

qos_get_max_buff_size.yml Signed-off-by: Wenda Ni <[email protected]>

Add logic to consider static thresholding

c203a73

Move XON and XOFF limit queries to the last because it is only specific to ingress lossless Signed-off-by: Wenda Ni <[email protected]>

Add the flexibility to query WRED profiles for various queue or

1723844

queue set Signed-off-by: Wenda Ni <[email protected]>

Copy portmap for A7050-QX-32S

84b20f1

Signed-off-by: Wenda Ni <[email protected]>

Show the type of buffer profile we retrieve when calling qos_get_max_…

8ff7e88

…buff_size.yml Signed-off-by: Wenda Ni <[email protected]>

Correct code format

bb2b52a

Signed-off-by: Wenda Ni <[email protected]>

Move the test buffer profile generation and restore to be

8e994ac

Mellanox-specific Signed-off-by: Wenda Ni <[email protected]>

Pass asic_type to PTF to skip some of the tests for broadcom.

f3a00b7

With this, the test can run on td2. Signed-off-by: Wenda Ni <[email protected]>

Change cell size for td2 in qos.yml

878111f

Signed-off-by: Wenda Ni <[email protected]>

Ignore pkt_num_leak_out, pkt_num_trig_pfc, pkt_num_trig_ingr_drp for …

4feb1d3

…mlnx devices Signed-off-by: Wenda Ni <[email protected]>

'Port' LossyQueueTest to td2

9d23b08

Signed-off-by: Wenda Ni <[email protected]>

Use SAI_PORT_STAT_IF_IN_DISCARDS to check ingress drop instead of

fca88fe

SAI_PORT_STAT_ETHER_STATS_DROP_EVENTS Signed-off-by: Wenda Ni <[email protected]>

Small changes to WRR test

3bbeddf

Signed-off-by: Wenda Ni <[email protected]>

Add qos parameters for TH and TH2

d5da30a

Signed-off-by: Wenda Ni <[email protected]>

Use rpc call to pause egress

80c4089

Refactor PFCtest Signed-off-by: Wenda Ni <[email protected]>

Refactor LossyQueueTest with the use of egress pause rpc call

8dd6c46

Signed-off-by: Wenda Ni <[email protected]>

[PFCtest] Update the recv_counters_base for each incremental packet s…

3c23210

…ending event Signed-off-by: Wenda Ni <[email protected]>

wendani added 22 commits September 18, 2019 12:27

Code format change

70351db

Signed-off-by: Wenda Ni <[email protected]>

Port and improve watermark pg headroom test

418b648

Signed-off-by: Wenda Ni <[email protected]>

Remove commented codes

6263826

Signed-off-by: Wenda Ni <[email protected]>

Port and improve watermark pg shared pool test

242303b

Signed-off-by: Wenda Ni <[email protected]>

Remove commented codes

50fe84a

Signed-off-by: Wenda Ni <[email protected]>

Port and improve watermark queue shared pool test

1c3dd45

Signed-off-by: Wenda Ni <[email protected]>

Remove commented codes

c1eed62

Signed-off-by: Wenda Ni <[email protected]>

Change terminology from pg to queue to be conceptually precise in queue

97cccdb

shared watermark test Signed-off-by: Wenda Ni <[email protected]>

Formalize pg and queue watermark tests

2d4f16c

Signed-off-by: Wenda Ni <[email protected]>

Update code format; Fix comment typo

ceb6bdd

Signed-off-by: Wenda Ni <[email protected]>

Add dscp to pg mapping test

8097593

Signed-off-by: Wenda Ni <[email protected]>

Fix dscp to pg mapping coding error

0d7999b

Signed-off-by: Wenda Ni <[email protected]>

assert that irrelevant pgs do not have counters increment in the dscp pg

be46dda

mapping test Signed-off-by: Wenda Ni <[email protected]>

Implement buffer pool watermark read

ea354fa

Signed-off-by: Wenda Ni <[email protected]>

Fix watermark polling status query

cc92177

Add egress lossy profile query Signed-off-by: Wenda Ni <[email protected]>

Code format change

b8321f0

Signed-off-by: Wenda Ni <[email protected]>

Fix watermark polling status restore

2faf1ea

Signed-off-by: Wenda Ni <[email protected]>

Add buffer pool watermark test

379bb1f

Signed-off-by: Wenda Ni <[email protected]>

Add DWRR run-time weight change test

1fe24d7

Signed-off-by: Wenda Ni <[email protected]>

Add dot1p to queue mapping test

293f88a

Signed-off-by: Wenda Ni <[email protected]>

Send a q-in-q packet for dot1p to queue mapping test

f180f48

Signed-off-by: Wenda Ni <[email protected]>

Add dot1p to pg mapping test

ded5585

Signed-off-by: Wenda Ni <[email protected]>

lguohan approved these changes Sep 27, 2019

View reviewed changes

lguohan merged commit 658b81e into sonic-net:master Sep 27, 2019

wendani added the Request for 201811 branch label Oct 15, 2019

yxieca pushed a commit that referenced this pull request Oct 17, 2019

Merge pull request #1119 from wendani/qos_sai_master

07003d0

Upstream QoS SAI test

yxieca added the Included in 201811 branch label Oct 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upstream QoS SAI test#1119

Upstream QoS SAI test#1119
lguohan merged 94 commits intosonic-net:masterfrom
wendani:qos_sai_master

wendani commented Sep 18, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

wendani commented Sep 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Approach

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wendani commented Sep 18, 2019 •

edited

Loading